Hi Shunqian, Thanks for the patchset.
On Fri, Dec 29, 2017 at 04:08:23PM +0800, Shunqian Zheng wrote: > Add device tree binding documentation for the OV5695 sensor. > > Signed-off-by: Shunqian Zheng <[email protected]> > --- > .../devicetree/bindings/media/i2c/ov5695.txt | 38 > ++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5695.txt > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov5695.txt > b/Documentation/devicetree/bindings/media/i2c/ov5695.txt > new file mode 100644 > index 0000000..8d87dbc > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/ov5695.txt > @@ -0,0 +1,38 @@ > +* Omnivision OV5695 MIPI CSI-2 sensor > + > +Required Properties: > +- compatible: should be "ovti,ov5695" s/should/shall/ > +- clocks: reference to the 24M xvclk input clock. I presume 24 MHz may be currently assumed by the driver but it's not a property of the sensor. You should therefore check the frequency in the driver instead. > +- clock-names: should be "xvclk". > +- dovdd-supply: Digital I/O voltage supply, 1.8 volts > +- avdd-supply: Analog voltage supply, 2.8 volts > +- dvdd-supply: Digital core voltage supply, 1.2 volts > +- reset-gpios: Low active reset gpio > + > +The device node must contain one 'port' child node for its digital output s/must/shall/ Please add that it shall also contain one endpoint node. > +video port, in accordance with the video interface bindings defined in > +Documentation/devicetree/bindings/media/video-interfaces.txt. Which properties are mandatory? You may leave out remote-endpoint as it's already required by the video interface bindings --- the rest are hardware specific in a way or another. > + > +Example: > +&i2c1: camera-sensor@36 { > + compatible = "ovti,ov5695"; > + reg = <0x36>; > + pinctrl-names = "default"; > + pinctrl-0 = <&clk_24m_cam>; > + > + clocks = <&cru SCLK_TESTCLKOUT1>; > + clock-names = "xvclk"; > + > + avdd-supply = <&pp2800_cam>; > + dvdd-supply = <&pp1250_cam>; > + dovdd-supply = <&pp1800>; > + > + reset-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>; > + > + port { > + wcam_out: endpoint { > + remote-endpoint = <&mipi_in_wcam>; > + data-lanes = <1 2>; > + }; > + }; > +}; -- Sakari Ailus e-mail: [email protected]
