From: Colin Ian King <colin.k...@canonical.com>

pi_buff is being memset before it is sanity checked. Move the
memset after the null pi_buff sanity check to avoid an oops.

Signed-off-by: Colin Ian King <colin.k...@canonical.com>
---
 arch/powerpc/platforms/pseries/hvcserver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/pseries/hvcserver.c 
b/arch/powerpc/platforms/pseries/hvcserver.c
index eedb645..94a6e56 100644
--- a/arch/powerpc/platforms/pseries/hvcserver.c
+++ b/arch/powerpc/platforms/pseries/hvcserver.c
@@ -142,11 +142,11 @@ int hvcs_get_partner_info(uint32_t unit_address, struct 
list_head *head,
        int more = 1;
        int retval;
 
-       memset(pi_buff, 0x00, PAGE_SIZE);
        /* invalid parameters */
        if (!head || !pi_buff)
                return -EINVAL;
 
+       memset(pi_buff, 0x00, PAGE_SIZE);
        last_p_partition_ID = last_p_unit_address = ~0UL;
        INIT_LIST_HEAD(head);
 
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to