Commit-ID:  def02db0d662b0edd83f80e3c18f660fc414decb
Gitweb:     http://git.kernel.org/tip/def02db0d662b0edd83f80e3c18f660fc414decb
Author:     Arnaldo Carvalho de Melo <a...@redhat.com>
AuthorDate: Mon, 5 Oct 2015 17:05:35 -0300
Committer:  Arnaldo Carvalho de Melo <a...@redhat.com>
CommitDate: Mon, 5 Oct 2015 17:59:43 -0300

perf callchain: Switch default to 'graph,0.5,caller'

Which is the most common default found in other similar tools.

Requested-by: Ingo Molnar <mi...@kernel.org>
Cc: Adrian Hunter <adrian.hun...@intel.com>
Cc: Borislav Petkov <b...@suse.de>
Cc: Chandler Carruth <chandl...@gmail.com>
Cc: David Ahern <dsah...@gmail.com>
Cc: Frederic Weisbecker <fweis...@gmail.com>
Cc: Jiri Olsa <jo...@redhat.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Stephane Eranian <eran...@google.com>
Cc: Wang Nan <wangn...@huawei.com>
Link: https://www.youtube.com/watch?v=nXaxk27zwlk
Link: http://lkml.kernel.org/n/tip-v8lq36aispvdwgxdmt9p9...@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <a...@redhat.com>
---
 tools/perf/Documentation/perf-report.txt | 2 +-
 tools/perf/builtin-report.c              | 4 ++--
 tools/perf/util/util.c                   | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/tools/perf/Documentation/perf-report.txt 
b/tools/perf/Documentation/perf-report.txt
index ce49903..e4fdeeb 100644
--- a/tools/perf/Documentation/perf-report.txt
+++ b/tools/perf/Documentation/perf-report.txt
@@ -192,7 +192,7 @@ OPTIONS
        when available. Usually more convenient to use --branch-history
        for this.
 
-       Default: fractal,0.5,callee,function.
+       Default: graph,0.5,caller
 
 --children::
        Accumulate callchain of children to parent entry so that then can
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index b562363..3b23b25 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -633,7 +633,7 @@ int cmd_report(int argc, const char **argv, const char 
*prefix __maybe_unused)
        bool has_br_stack = false;
        int branch_mode = -1;
        bool branch_call_mode = false;
-       char callchain_default_opt[] = "fractal,0.5,callee";
+       char callchain_default_opt[] = "graph,0.5,caller";
        const char * const report_usage[] = {
                "perf report [<options>]",
                NULL
@@ -701,7 +701,7 @@ int cmd_report(int argc, const char **argv, const char 
*prefix __maybe_unused)
                    "Only display entries with parent-match"),
        OPT_CALLBACK_DEFAULT('g', "call-graph", &report, 
"output_type,min_percent[,print_limit],call_order[,branch]",
                     "Display callchains using output_type (graph, flat, 
fractal, or none) , min percent threshold, optional print limit, callchain 
order, key (function or address), add branches. "
-                    "Default: fractal,0.5,callee,function", 
&report_parse_callchain_opt, callchain_default_opt),
+                    "Default: graph,0.5,caller", &report_parse_callchain_opt, 
callchain_default_opt),
        OPT_BOOLEAN(0, "children", &symbol_conf.cumulate_callchain,
                    "Accumulate callchains of children and show total overhead 
as well"),
        OPT_INTEGER(0, "max-stack", &report.max_stack,
diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
index ce465b2..c1bf9ff 100644
--- a/tools/perf/util/util.c
+++ b/tools/perf/util/util.c
@@ -17,9 +17,9 @@
 #include "callchain.h"
 
 struct callchain_param callchain_param = {
-       .mode   = CHAIN_GRAPH_REL,
+       .mode   = CHAIN_GRAPH_ABS,
        .min_percent = 0.5,
-       .order  = ORDER_CALLEE,
+       .order  = ORDER_CALLER,
        .key    = CCKEY_FUNCTION
 };
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to