On 10-08-15, 23:02, Stephen Boyd wrote: > > - if (prop->length != sizeof(__be32)) { > > - dev_err(dev, "%s: Invalid opp desc phandle\n", __func__); > > - return ERR_PTR(-EINVAL); > > - } > > But we lost this check? Perhaps we can use > of_count_phandle_with_args() to make suer we only have one > phandle?
I thought about it earlier and it looked like we don't need to care about this. Even if the user passes multiple strings here, its his problem. We will just pick the first entry and parse it. And that's true until the point we support multiple table entries, ofcourse :) Now that you are still awake, let me update the other patches as well where u commented :) -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/