> ----- Original Message ----- > From: "Michal Hocko" <mho...@kernel.org> ... > On Sat 01-08-15 14:49:22, Ulrich Obergfell wrote: >> These functions are intended to be used only from inside kernel/watchdog.c >> to park/unpark all watchdog threads that are specified in watchdog_cpumask. > > I would suggest merging this into Patch2. It is usually better to add > new functions along with their users.
Michal, watchdog_{park|unpark}_threads are called by watchdog_{suspend|resume} in Patch 2/4 and by update_watchdog_all_cpus() in Patch 3/4, so I would have to merge three patches into one, and I would end up with one large patch and one smaller patch. I think the result would be harder to read, review and understand. Thus I'd prefer to leave the patches split as they currently are. Regards, Uli -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/