On Tue 04-08-15 10:27:50, Don Zickus wrote:
> On Tue, Aug 04, 2015 at 03:31:30PM +0200, Michal Hocko wrote:
> > On Sat 01-08-15 14:49:25, Ulrich Obergfell wrote:
> > [...]
> > > @@ -3368,7 +3368,10 @@ static __init int fixup_ht_bug(void)
> > > return 0;
> > > }
> > >
> > > - watchdog_nmi_disable_all();
> > > + if (watchdog_suspend() != 0) {
> > > + pr_info("failed to disable PMU erratum BJ122, BV98, HSD29
> > > workaround\n");
> > > + return 0;
> > > + }
> >
> > Is this really worth reporting to the log? What is an admin supposed to
> > do about it?
>
> I think it was more for developers to aid in debugging a strange behaviour
> of the performance counters.
pr_debug then?
> > <looking into the code>
> > Ok, so kthread_park fails only when the kernel thread has already
> > exited. Can this ever happen during this call path?
>
> It might be overkill, but it is just a harmless informational failure
> message.
Maybe we have way too many of those harmless informational failure
admins scratch their heads about...
--
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
