On Thu, Jul 23, 2015 at 10:19:52AM -0400, Jason Baron wrote: > > > > #define static_branch_likely(x) > > \ > > ({ > > \ > > bool branch; > > \ > > if (__builtin_types_compatible_p(typeof(x), struct static_key_true)) > > \ > > branch = !arch_static_branch(&(x)->key, false); > > \ > > else if (__builtin_types_compatible_p(typeof(x), struct > > static_key_false)) \ > > branch = !arch_static_branch_jump(&(x)->key, true); > > \ > > else > > \ > > branch = ____wrong_branch_error(); > > \ > > branch; > > \ > > }) > > > > #define static_branch_unlikely(x) > > \ > > ({ > > \ > > bool branch; > > \ > > if (__builtin_types_compatible_p(typeof(x), struct static_key_true)) > > \ > > branch = arch_static_branch(&(x)->key, true); > > \ > > else if (__builtin_types_compatible_p(typeof(x), struct > > static_key_false)) \ > > branch = arch_static_branch_jump(&(x)->key, false); > > \ > > else > > \ > > branch = ____wrong_branch_error(); > > \ > > branch; > > \ > > }) > > > > In 'static_branch_unlikely()', I think arch_static_branch() and > arch_static_branch_jump() are reversed.
Yes, you're right. But I think I need a nap before touching this stuff again :-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/