Hello, special_mapping_fault() is absolutely broken. It seems it was always wrong, but this didn't matter until vdso/vvar started to use more than one page.
The patches are the same, just 1/3 was re-diffed on top of the recent 6b7339f4c31ad "mm: avoid setting up anonymous pages into file mapping" from Kirill. And after this change vma_is_anonymous() becomes really trivial, it simply checks vm_ops == NULL. However, I do think the helper makes sense. There are a lot of ->vm_ops != NULL checks, the helper makes the caller's code more understandable (self-documented) and this is more grep-friendly. Oleg. include/linux/mm.h | 5 +++++ mm/memory.c | 8 ++++---- mm/mmap.c | 14 +++----------- 3 files changed, 12 insertions(+), 15 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
