On 06/26/2015 12:15 AM, Junichi Nomura wrote: > Hi Jens, > > On 06/25/15 23:37, Jens Axboe wrote: >> block, dm: don't copy bios for request clones > > this change should not be pushed to mainline yet. > > Firstly, Christoph has a newer version of the patch that fixes silent > data corruption problem: > https://www.redhat.com/archives/dm-devel/2015-May/msg00229.html > > And the new version still depends on LLDDs to always complete requests > to the end when error happens, while block API doesn't enforce such a > requirement. If the assumption is ever broken, the inconsistency between > request and bio (e.g. rq->__sector and rq->bio) will cause silent data > corruption: > https://www.redhat.com/archives/dm-devel/2015-June/msg00022.html
Why was none of that sent to the block tree? In any case, Linus, pick up Mike's pull request to fix this up. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
