On Mon, 1 Jun 2015, Baolin Wang wrote:
Subject line sucks.
> Introduce the do_sys_settimeofday64() function with timespec64 type to make
> it is ready for 2038 issue when setting the time of day.
>
> And move the do_sys_settimeofday() function to the timekeeping.h file, that it
> is convenient to delete it later.
See other mails.
> extern void do_gettimeofday(struct timeval *tv);
> extern int do_settimeofday64(const struct timespec64 *ts);
> -extern int do_sys_settimeofday(const struct timespec *tv,
> - const struct timezone *tz);
> +extern int do_sys_settimeofday64(const struct timespec64 *tv,
> + const struct timezone *tz);
> +static inline int do_sys_settimeofday(const struct timespec *tv,
> + const struct timezone *tz)
> +{
> + struct timespec64 ts64;
> +
> + ts64 = timespec_to_timespec64(*tv);
> + return do_sys_settimeofday64(&ts64, tz);
If you write it:
struct timespec64 ts64 = timespec_to_timespec64(*tv);
return do_sys_settimeofday64(&ts64, tz);
You spare a line per inline function. Applies to the other patches as well.
>
> -int do_sys_settimeofday(const struct timespec *tv, const struct timezone *tz)
> +int do_sys_settimeofday64(const struct timespec64 *tv, const struct timezone
> *tz)
> {
> static int firsttime = 1;
> int error = 0;
>
> - if (tv && !timespec_valid(tv))
> + if (tv && !timespec64_valid(tv))
> return -EINVAL;
>
> - error = security_settime(tv, tz);
> + error = security_settime64(tv, tz);
No such function. Fails to build.
Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
