Dear Arnd Bergmann, On Tue, 12 May 2015 17:49:08 +0200, Arnd Bergmann wrote:
> Using > > if (IS_ENABLED(__BIG_ENDIAN)) > > here would make it more readable by avoiding the #if. Alternatively, > you could leave the XOR_DESCRIPTOR_SWAP flag disabled and just swap > the descriptors manually like a lot of other drivers do. You have > to swap the mmio accesses anywya. Agreed on IS_ENABLED(). However, I don't understand the comment about the need to swap mmio accesses? We're using readl_relaxed() / writel_relaxed(), and they do the swapping already. Am I missing something? Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
