On 29/04/15 10:49, Maciej W. Rozycki wrote: > On Wed, 29 Apr 2015, James Hogan wrote: > >>> Error recovery pointers for fixups was improperly set as ".word" >>> which is unsuitable for MIPS64. >>> >>> Replaced by __stringify(PTR) >> >> Every other case of this sort of thing uses STR(PTR) (or __UA_ADDR in >> uaccess.h). Can we stick to STR(PTR) for consistency please? > > Or __PA_ADDR in paccess.h. > > I have mixed feelings, the reason for __stringify being absent is the > macro being generic and more recently added than pieces of code that use > STR, e.g. unaligned.c that has been there since forever. And we do use > __stringify in many other cases.
Well I don't particularly mind, so feel free to add my Reviewed-by regardless, though it'd be nice to have some consistency eventually one way or another. Cheers James > > On the other hand STR is short and sweet, unlike __stringify. > > So how about adding a macro like __STR_PTR that expands to > __stringify(PTR) and converting all the places throughout our port > (including ones currently using __UA_ADDR/__PA_ADDR) to use the new macro? > > Leonid's bug fix will need to go in first of course. > > Maciej >
signature.asc
Description: OpenPGP digital signature
