On Thu, Apr 23, 2015 at 6:08 AM, Andreas Noever
<andreas.noe...@gmail.com> wrote:
> Hi Adam,
>
> On my system (MacBookPro10,1 - 4 channel TB1) the bridges and the
> controller both use 0x1547 and are only differentiated by
> subvendor/subdevice.
>
> 0x156c is the 4 channel TB2 controller and was originally added by
> Matthew. Judging from his patch it looks like the subvendor/subdevice
> is set on his system:
> http://patchwork.ozlabs.org/patch/354626/
>
> But it also indicates that the bridges already use different ids. If
> that is the case then we can drop the subvendor/subdevice for 0x156c.
> Matthew can you confirm that on your system 0x156c is used only for
> the controller?
>
> Adam, could you check that suspend/resume works properly? Also your
> bugzilla report suggest that hotplug might now work without the
> driver. Could you try to revert the _OSI check (and disable the
> driver) and check whether everything "just works"?
>
In _OSI("Darwin") mode, suspend/resume doesn't work. It failed to come
back from suspend.
I have to rebuild the kernel and remove Darwin again, but I will test
suspend/resume in "Windows 2012" mode later.
>From previous testing, hotplug doesn't automatically work in "Windows
2012" mode. It exhibits the standard no-driver behavior where devices
are not detected after boot. But even in "Windows 2012" mode I still
do get the 0x156c device, which I think used to be hidden if !Darwin.
More testing coming...
Adam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
