On 04/08/15 02:07, Pratyush Anand wrote:
Hi Dave,

On Wed, Feb 18, 2015 at 4:41 AM, David Long <dave.l...@linaro.org> wrote:

From: Sandeepa Prabhu <sandeepa.pra...@linaro.org>

Add support for basic kernel probes(kprobes) and jump probes
(jprobes) for ARM64.


[...]


+#ifdef CONFIG_KPROBES
+static inline int notify_page_fault(struct pt_regs *regs, unsigned int esr)
+{
+       int ret = 0;
+
+       /* kprobe_running() needs smp_processor_id() */
+       if (!user_mode(regs)) {
+               preempt_disable();
+               if (kprobe_running() && kprobe_fault_handler(regs, esr))
+                       ret = 1;
+               preempt_enable();
+       }
+
+       return ret;
+}
+#else
+static inline int notify_page_fault(struct pt_regs *regs)

Please fix this definition in next revision, other wise there would be
a build error
if CONFIG_KPROBES is not defined.


should be:

+static inline int notify_page_fault(struct pt_regs *regs, unsigned int esr)


~Pratyush


Yes, the fix is already in the v6 version I'm working on.

-dl

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to