On Thu, Apr 02, 2015 at 10:11:39AM +0200, Markus Pargmann wrote:
> +/*
> + * Forcibly shutdown the socket causing all listeners to error
> + */
> static void sock_shutdown(struct nbd_device *nbd, int lock)
> {
> - /* Forcibly shutdown the socket causing all listeners
> - * to error
> - *
> - * FIXME: This code is duplicated from sys_shutdown, but
> - * there should be a more generic interface rather than
> - * calling socket ops directly here */
> if (lock)
> mutex_lock(&nbd->tx_lock);
> if (nbd->sock) {
Please also kill the conditional locking here in a future patch by
moving it into the caller.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
