On Wed, Apr 01 2015, Sasha Levin <sasha.le...@oracle.com> wrote: > Rather than calling free_hot_cold_page() for every page, batch them up in a > list and pass them on to free_hot_cold_page_list(). This will let us defer > them to a workqueue. > > Signed-off-by: Sasha Levin <sasha.le...@oracle.com> > --- > mm/page_alloc.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 812ca75..e58e795 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -2997,12 +2997,16 @@ EXPORT_SYMBOL(get_zeroed_page); > > void __free_pages(struct page *page, unsigned int order) > { > + LIST_HEAD(hot_cold_pages); > + > if (put_page_testzero(page)) { > if (order == 0) > - free_hot_cold_page(page, false); > + list_add(&page->lru, &hot_cold_pages); > else > __free_pages_ok(page, order); > } > + > + free_hot_cold_page_list(&hot_cold_pages, false);
Is there a reason to do this function call when the list is empty? In other words, why can't this just be done inside the if (order == 0)? Rasmus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/