On Fri, Mar 27, 2015 at 10:18:14AM +0000, Punit Agrawal wrote: > Hi Sascha, > > Sascha Hauer <s.ha...@pengutronix.de> writes: > > > The thermal framework uses int, long and unsigned long for temperatures > > in millicelsius. The majority of functions uses unsigned long, so change > > the remaining functions to use this type aswell. > > > > Signed-off-by: Sascha Hauer <s.ha...@pengutronix.de> > > I'd suggest changing to long instead. It would allow the use of the > thermal framework in environments where temperatures are below 0C - > quite easily reached in many parts of the world.
I agree to use a signed type. I also found it not so nice that the thermal core does not support negative temperatures. I only chose unsigned long because the patch got smallest that way, but I already expected this answer ;) We could also use int instead of long. INT_MAX °mC is still enough for using a computer on the surface of the sun (Not for the center though) Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
