On Fri, Mar 27, 2015 at 01:05:08PM -0400, ira.weiny wrote:

> > But it seems redudent, since mcast_add_one will already not add a port that 
> > is
> > not IB, so mcast_event_handler is not callable. Something to do with
> > rocee/ib switching?
> 
> I'm not sure about this either.  This check seems to be necessary only on a
> per-port level.  It does seem apparent that one can't go from Eth to IB.  What
> happens if you go from IB to Eth on the port?

Hmm... I see a mlx4_change_port_types which ultimately calls
ib_unregister_device, which suggests the port type doesn't change at
runtime (yay)

So maybe these checks really are redundant?

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to