Hello.
On 3/2/2015 4:06 PM, Jan Kasprzak wrote:
: >avoid out-of-bounds-read by checking count before indexing.
:
: >Signed-off-by: Ameen Ali <ameenali...@gmail.com>
: >---
: > drivers/net/wan/cosa.c | 2 +-
: > 1 file changed, 1 insertion(+), 1 deletion(-)
:
: >diff --git a/drivers/net/wan/cosa.c b/drivers/net/wan/cosa.c
: >index 83c39e2..5252e21 100644
: >--- a/drivers/net/wan/cosa.c
: >+++ b/drivers/net/wan/cosa.c
: >@@ -376,7 +376,7 @@ static int __init cosa_init(void)
: > }
: > for (i=0; i<MAX_CARDS; i++)
: > cosa_cards[i].num = -1;
: >- for (i=0; io[i] != 0 && i < MAX_CARDS; i++)
: >+ for (i=0; (i < MAX_CARDS) && (io[i] != 0) ; i++)
: Parens you've added aren't necessary.
Yes, but I am OK with both variants.
Anyway, space before ; should be removed (just noticed).
: I suggest to add spaces after and before = in the first expression.
In that case, also the upper for() cycle should be modified
to match this. I don't think this is necessary.
As long as it doesn't cause complaints from scripts/checkpatch.pl...
-Yenya
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
