* Joerg Roedel <j...@8bytes.org> wrote:
> On Thu, Feb 12, 2015 at 06:08:45PM -0800, Linus Torvalds wrote:
> > Any ideas? The Pixel Chromebook does have an odd and often broken
> > BIOS/firmware thing, but it *used* to suspend and resume very reliably
> > once we got around its insane TPM thing.
>
> Hmm, looking at the patch and the surrounding code my guess is that
> x2apic gets enabled now with 5fcee53ce705 on your Chromebook Pixel at
> boot, which causes the suspend issue later for other reasons.
>
> So the condition should rather look like this to keep x2apic disabled
> like before:
>
> diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
> index b665d24..770a0bb 100644
> --- a/arch/x86/kernel/apic/apic.c
> +++ b/arch/x86/kernel/apic/apic.c
> @@ -1580,8 +1580,8 @@ static __init void try_to_enable_x2apic(int remap_mode)
> * under KVM
> */
> if (max_physical_apicid > 255 ||
> - (IS_ENABLED(CONFIG_HYPERVISOR_GUEST) &&
> - !hypervisor_x2apic_available())) {
> + !(IS_ENABLED(CONFIG_HYPERVISOR_GUEST) &&
> + hypervisor_x2apic_available())) {
> pr_info("x2apic: IRQ remapping doesn't support X2APIC
> mode\n");
> x2apic_disable();
> return;
Indeed!
> Another solution would be to just revert 5fcee53ce705.
> This code is not in any fast-path, so we can live well
> without that optimization.
Agreed.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
