On Fri, Jan 30, 2015 at 07:23:21AM +0000, Yang, Wenyou wrote: [...]
> > > > > + */ > > > > > + isb > > > > This isb should not be there, unless you know a reason why it should and you > > explain it to me. > I encountered system lock during verifying the pm function. > Anyway, I will tested again whether it works after removing it. Re-checked the code flow, I see no reason why this isb should be there. Adding barriers changes code execution, this might paper over some issues instead of solving them, so every single barrier should be commented and added with a specific purpose that I do not see here. Lorenzo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
