Wrong type in printf format string, requires 'unsigned int'
but the argument type is 'int'

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
---
 drivers/staging/lustre/lustre/libcfs/nidstrings.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/lustre/lustre/libcfs/nidstrings.c 
b/drivers/staging/lustre/lustre/libcfs/nidstrings.c
index 47c239f..634ad09 100644
--- a/drivers/staging/lustre/lustre/libcfs/nidstrings.c
+++ b/drivers/staging/lustre/lustre/libcfs/nidstrings.c
@@ -343,7 +343,7 @@ libcfs_lnd2str(int lnd)
                return nf->nf_name;
 
        str = libcfs_next_nidstring();
-       snprintf(str, LNET_NIDSTR_SIZE, "?%u?", lnd);
+       snprintf(str, LNET_NIDSTR_SIZE, "?%d?", lnd);
        return str;
 }
 EXPORT_SYMBOL(libcfs_lnd2str);
@@ -369,11 +369,11 @@ libcfs_net2str(__u32 net)
        char         *str = libcfs_next_nidstring();
 
        if (nf == NULL)
-               snprintf(str, LNET_NIDSTR_SIZE, "<%u:%u>", lnd, num);
+               snprintf(str, LNET_NIDSTR_SIZE, "<%d:%d>", lnd, num);
        else if (num == 0)
                snprintf(str, LNET_NIDSTR_SIZE, "%s", nf->nf_name);
        else
-               snprintf(str, LNET_NIDSTR_SIZE, "%s%u", nf->nf_name, num);
+               snprintf(str, LNET_NIDSTR_SIZE, "%s%d", nf->nf_name, num);
 
        return str;
 }
@@ -397,7 +397,7 @@ libcfs_nid2str(lnet_nid_t nid)
        str = libcfs_next_nidstring();
 
        if (nf == NULL)
-               snprintf(str, LNET_NIDSTR_SIZE, "%x@<%u:%u>", addr, lnd, nnum);
+               snprintf(str, LNET_NIDSTR_SIZE, "%x@<%d:%d>", addr, lnd, nnum);
        else {
                nf->nf_addr2str(addr, str);
                nob = strlen(str);
@@ -405,7 +405,7 @@ libcfs_nid2str(lnet_nid_t nid)
                        snprintf(str + nob, LNET_NIDSTR_SIZE - nob, "@%s",
                                 nf->nf_name);
                else
-                       snprintf(str + nob, LNET_NIDSTR_SIZE - nob, "@%s%u",
+                       snprintf(str + nob, LNET_NIDSTR_SIZE - nob, "@%s%d",
                                 nf->nf_name, nnum);
        }
 
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to