On Fri, 23 Jan 2015, Daniel Church wrote: > + overruns = (unsigned int) hrtimer_forward(timer, > + timer->base->get_time(), > + timr->it.real.interval); > + if (overruns >= delaytimer_max || > + (timr->it_overrun >= 0 && > + timr->it_overrun >= delaytimer_max - overruns)) { > + timr->it_overrun = delaytimer_max; > + } else { > + timr->it_overrun += overruns; > + }
We certainly do not add the same logic 3 times via copy and paste. Please make that a proper helper function. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/