On 08/01/15 10:17, Lad, Prabhakar wrote: > this patch checks the return value of write command while > setting the display offset. > > Signed-off-by: Lad, Prabhakar <prabhakar.cse...@gmail.com> > --- > drivers/video/fbdev/ssd1307fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c > index 70e3ce8..a7ecaa6 100644 > --- a/drivers/video/fbdev/ssd1307fb.c > +++ b/drivers/video/fbdev/ssd1307fb.c > @@ -342,7 +342,7 @@ static int ssd1307fb_ssd1306_init(struct ssd1307fb_par > *par) > > /* set display offset value */ > ret = ssd1307fb_write_cmd(par->client, SSD1307FB_SET_DISPLAY_OFFSET); > - ret = ssd1307fb_write_cmd(par->client, 0x20); > + ret = ret & ssd1307fb_write_cmd(par->client, 0x20); > if (ret < 0) > return ret;
Hrm, what's that supposed to do? If both calls to ssd1307fb_write_cmd() return an error, they are anded, resulting in a garbage error code... Tomi
signature.asc
Description: OpenPGP digital signature
