On 01/09/2015 06:37 PM, Richard Weinberger wrote: > Am 09.01.2015 um 22:32 schrieb Ezequiel Garcia: >> On 11/24/2014 10:20 AM, Richard Weinberger wrote: >>> ...otherwise the deferred work might run after datastructures >>> got freed and corrupt memory. >>> >>> Signed-off-by: Richard Weinberger <[email protected]> >>> --- >>> drivers/mtd/ubi/wl.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c >>> index 7f135df..cb2e571 100644 >>> --- a/drivers/mtd/ubi/wl.c >>> +++ b/drivers/mtd/ubi/wl.c >>> @@ -2041,6 +2041,9 @@ static void protection_queue_destroy(struct >>> ubi_device *ubi) >>> void ubi_wl_close(struct ubi_device *ubi) >>> { >>> dbg_wl("close the WL sub-system"); >>> +#ifdef CONFIG_MTD_UBI_FASTMAP >>> + flush_work(&ubi->fm_work); >>> +#endif >>> shutdown_work(ubi); >>> protection_queue_destroy(ubi); >>> tree_destroy(&ubi->used); >>> >> >> IMHO, it's best to avoid nasty ifdefs like this (there are lots of ways >> of getting it cleaner). But I guess it's not a big deal. > > I agree that's why I've cleaned up the vast majority of all ifdefs in a later > cleanup > commit. My original plan was to have first pure bug fixes and then cleanups > to make > backporting of my patches easy. >
Ah, yes, backporting is a good point. -- Ezequiel Garcia, VanguardiaSur www.vanguardiasur.com.ar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
