On Thu, 11 Dec 2014, Yinghai Lu wrote:
> On Thu, Dec 11, 2014 at 11:48 AM, Thomas Gleixner <t...@linutronix.de> wrote:
> > +static inline bool is_valid_mem_resource(struct resource *res)
> > +{
> > + return !(res->flags & IORESOURCE_DISABLED) &&
> > + (res->flags & IORESOURCE_MEM);
> > +}
> > +
> There is minor problem about mem pref handling, original code will ignore
> them.
Bah. I missed that in that well documented function...
> with this patch will let it follow through.
>
> should change is_valid_mem_resource to is_valid_mem_nonpref_resource()...
>
> +static inline bool is_valid_mem_nonpref_resource(struct resource *res)
> {
> return !(res->flags & IORESOURCE_DISABLED) &&
> - (res->flags & IORESOURCE_MEM);
> + (res->flags & IORESOURCE_MEM) &&
> + !(res->flags & IORESOURCE_PREFETCH);
> }
Unfortunately that does not help, because nothing sets the
IORESOURCE_PREFETCH flag. Will fix it proper.
I still have no explanation why the translation offset needs to be
applied here.
Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
