2014-11-14 14:16 GMT-08:00 Dmitry Torokhov <d...@chromium.org>:
> Return value of irq_of_parse_and_map() is unsigned int, with 0
> indicating failure, so testing for negative result never works.
>
> Signed-off-by: Dmitry Torokhov <d...@chromium.org>
Acked-by: Florian Fainelli <f.faine...@gmail.com>
> ---
>
> Not tested, found by casual code inspection.
>
> drivers/irqchip/irq-brcmstb-l2.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-brcmstb-l2.c
> b/drivers/irqchip/irq-brcmstb-l2.c
> index 4aa653a..313c2c6 100644
> --- a/drivers/irqchip/irq-brcmstb-l2.c
> +++ b/drivers/irqchip/irq-brcmstb-l2.c
> @@ -139,9 +139,9 @@ int __init brcmstb_l2_intc_of_init(struct device_node *np,
> writel(0xffffffff, data->base + CPU_CLEAR);
>
> data->parent_irq = irq_of_parse_and_map(np, 0);
> - if (data->parent_irq < 0) {
> + if (!data->parent_irq) {
> pr_err("failed to find parent interrupt\n");
> - ret = data->parent_irq;
> + ret = -EINVAL;
> goto out_unmap;
> }
>
> --
> 2.1.0.rc2.206.gedb03e5
>
>
> --
> Dmitry
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
