(2014/11/06 11:04), Namhyung Kim wrote:
> When I run the ftracetest in a busybox docker container, I saw
> following error. Make the logfile template to comply with busybox's
> mktemp. It also keep the logfiles under the logs directory.
>
> # /linux/tools/testing/selftests/ftrace/ftracetest
> === Ftrace unit tests ===
> mktemp: unrecognized option
> `--tmpdir=/linux/tools/testing/selftests/ftrace/logs/20141106-003624/'
> BusyBox v1.22.1 (2014-05-22 23:22:11 UTC) multi-call binary.
>
> Usage: mktemp [-dt] [-p DIR] [TEMPLATE]
>
> Create a temporary file with name based on TEMPLATE and print its name.
> TEMPLATE must end with XXXXXX (e.g. [/dir/]nameXXXXXX).
> Without TEMPLATE, -t tmp.XXXXXX is assumed.
>
> -d Make directory, not file
> -q Fail silently on errors
> -t Prepend base directory name to TEMPLATE
> -p DIR Use DIR as a base directory (implies -t)
> -u Do not create anything; print a name
>
> Base directory is: -p DIR, else $TMPDIR, else /tmp
Oops! good catch :)
>
> [1] Basic trace file check/linux/tools/testing/selftests/ftrace/ftracetest:
> line 244: can't create : nonexistent directory
> /linux/tools/testing/selftests/ftrace/ftracetest: line 244: can't create :
> nonexistent directory
> [FAIL]
>
> Signed-off-by: Namhyung Kim <namhy...@kernel.org>
Acked-by: Masami Hiramatsu <masami.hiramatsu...@hitachi.com>
Thank you,
> ---
> tools/testing/selftests/ftrace/ftracetest | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/ftrace/ftracetest
> b/tools/testing/selftests/ftrace/ftracetest
> index 8cc01c14262f..93b1bf5eadb5 100755
> --- a/tools/testing/selftests/ftrace/ftracetest
> +++ b/tools/testing/selftests/ftrace/ftracetest
> @@ -218,7 +218,7 @@ trap 'SIG_RESULT=$XFAIL' $SIG_XFAIL
> # Run one test case
> run_test() { # testfile
> local testname=`basename $1`
> - local testlog=`mktemp --tmpdir=$LOG_DIR ${testname}-XXXXXX.log`
> + local testlog=`mktemp $LOG_DIR/${testname}-log.XXXXXX`
> testcase $1
> echo "execute: "$1 > $testlog
> SIG_RESULT=0
>
--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Research Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu...@hitachi.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
