On Sun, Oct 26, 2014 at 2:57 PM, Al Viro <v...@zeniv.linux.org.uk> wrote:
> .. snip ..
> in d_walk(), __list_del() instead of list_del() in __dentry_kill(),
> d_u.d_child
> turning into d_child everywhere, while d_alias turns into d_u.d_alias...
>
> It looks like that way we would get no retries on the second pass. Comments?
Since I missed the whole issue with d_child.next, I'm not sure any
comments from me would be helpful.
It does sound like trying to be more careful with d_child and using
d_alias instead is a good idea. d_alias is only used under the dentry
lock, and not in any horribly subtle situations, right? So that sounds
like a good change regardless of this particular fix - making the
union happen in a less nasty place..
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
