On 09/17, Roman Pen wrote:
>
> +void wait_for_rootfs(void)
> +{
> + /* Avoid waiting for ourselves */
> + if (is_global_init(current))
> + pr_warn("init: it is not a good idea to wait for the rootfs
> mount from the init task\n");
> + else
> + wait_event(rootfs_waitq, rootfs_mounted);
> +}
Well, this pr_warn() doesn't look very useful, how about
if (WARN_ON((is_global_init(current))))
return;
? this will show the caller.
> +static inline void wake_up_rootfs_waiters(void)
> +{
> + rootfs_mounted = true;
> + /* wake_up guarantees write memory barrier if and only if
> + there is a task to be woken up, it is not always true
> + for our case. */
Yes, but this doesn't matter. wait_event() takes care,
> + smp_wmb();
so please remove this wmb() and the comment.
Oleg.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
