On Fri, Sep 5, 2014 at 11:00 AM, Tejun Heo <t...@kernel.org> wrote: > On Fri, Sep 05, 2014 at 09:31:50AM -0700, Cong Wang wrote: >> On Fri, Sep 5, 2014 at 7:08 AM, Tejun Heo <t...@kernel.org> wrote: >> >> + /* It might not be safe to check TIF_MEMDIE for pm freeze. */ >> > >> > This is just another representation of the following code which isn't >> > particularly useful. Wouldn't it be better if the comment actually >> > explains why this might not be safe? >> >> I don't know actually, I never understand pm code, just don't >> want to take the risk of breaking it as you told. :) > > Let's please try to understand and explain it properly. Reading > intricate code like this w/ comment which doesn't really explain > anything can be very frustrating for other people reading the code.
That comment just explains why we need a cgroup_freezing() check, nothing else. If you don't think it helps, I can definitely remove it. > Rafael, can you please help? Rafael is known not responsive at least for this topic. :) > > Shouldn't the primary goal of the comment be explaining why we need > TIF_MEMDIE check there at all anyway? The deadlock possiblity is not > very obvious. > The changelog is not long enough?? ;-) I hate to copy+paste changelog into comments, changelog is essentially necessary for people to understand kernel code (at least networking) , so I don't think we have to move it into comments in this case. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
