> > diff --git a/include/net/busy_poll.h b/include/net/busy_poll.h
> > index 1d67fb6..8a33fb2 100644
> > --- a/include/net/busy_poll.h
> > +++ b/include/net/busy_poll.h
> > @@ -109,7 +109,8 @@ static inline bool sk_busy_loop(struct sock *sk, int
> > nonblock)
> > cpu_relax();
> >
> > } while (!nonblock && skb_queue_empty(&sk->sk_receive_queue) &&
> > - !need_resched() && !busy_loop_timeout(end_time));
> > + !need_resched() && !busy_loop_timeout(end_time) &&
> > + nr_running_this_cpu() < 2);
So it's generally a bad idea to couple to the scheduler through
such a low level, implementation dependent value like
'nr_running', causing various problems:
- It misses important work that might be pending on this CPU,
like RCU callbacks.
- It will also over-credit task contexts that might be
runnable, but which are less important than the currently
running one: such as a SCHED_IDLE task
- It will also over-credit even regular SCHED_NORMAL tasks, if
this current task is more important than them: say
SCHED_FIFO. A SCHED_FIFO workload should run just as fast
with SCHED_NORMAL tasks around, as a SCHED_NORMAL workload
on an otherwise idle system.
So what you want is a more sophisticated query to the
scheduler, a sched_expected_runtime() method that returns the
number of nsecs this task is expected to run in the future,
which returns 0 if you will be scheduled away on the next
schedule(), and returns infinity for a high prio SCHED_FIFO
task, or if this SCHED_NORMAL task is on an otherwise idle CPU.
It will return a regular time slice value in other cases, when
there's some load on the CPU.
The polling logic can then do its decision based on that time
value.
All this can be done reasonably fast and lockless in most
cases, so that it can be called from busy-polling code.
An added advantage would be that this approach consolidates the
somewhat random need_resched() checks into this method as well.
In any case I don't agree with the nr_running_this_cpu()
method.
(Please Cc: me and lkml to future iterations of this patchset.)
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
