On Wed, 13 Aug 2014 22:47:43 +0200, Stephane Eranian wrote: > On Wed, Aug 13, 2014 at 10:37 PM, Arnaldo Carvalho de Melo > <a...@kernel.org> wrote: >> >> Em Wed, Aug 13, 2014 at 01:07:30AM +0200, Stephane Eranian escreveu: >> > On Tue, Aug 12, 2014 at 10:16 AM, Namhyung Kim <namhy...@kernel.org> wrote: >> > > The perf top TUI lacks 'z' key support to toggle sample zeroing. >> > > Add it. >> > > >> > Works for me. >> > Tested-by: Stephane Eranian <eran...@google.com> >> >> One thing that can be improved: Make it trigger a refresh in the right >> after 'z' is pressed. >> >> Also, this toggles the zeroing before each sample, it would be nice to >> have a visual cue that this is in effect, probably in the first line in >> the screen, perhaps on the far right, something like [z] when this is in >> effect and nothing when not. >> > I agree. Had to run a test on the side to verify that it was actually doing > the right thing. > >> >> Right now the way to figure this out is to observe the number of >> samples, if it increases monotonically, zeroing before refresh is not in >> effect, if it goes from a high number to a smaller or vice versa, >> zeroing is in effect :-) >> >> Anyway, applied, people wanting this feature can figure this out, what I >> suggested is just polishing. >> > We need to visual cue.
Got it. Will add [z] on the header line. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
