On Wed, 06 Aug 2014 13:53:17 -0400, Nick Krause said: > Remove unused definition which cause the following warnings > > drivers/spi/spi-omap-100k.c:73:0: warning: "WRITE" redefined [enabled by > default] > include/linux/fs.h:193:0: note: this is the location of the previous > definition > drivers/spi/spi-omap-100k.c:74:0: warning: "READ" redefined [enabled by > default] > include/linux/fs.h:192:0: note: this is the location of the previous > definition
> -#define WRITE 0 > -#define READ 1 NAK. Full stop. These are potentially used in an inner macro someplace, and by removing these, the conflicting values from fs.h will be used instead. #define READ 0 #define WRITE RW_MASK So if there *is* a use in an inner macro, you just screwed the pooch and introduced a bug in this "clean up" - somebody will be expecting to see a 0 for a READ, and will receive a 1 instead. This can't end well. Nick - how *exactly* did you identify that these are in fact not used? Given your history of submitting poorly researched patches, you're going to have to justify the "unused" better than the handwaving you've done here.
pgpqI0ibq2eAV.pgp
Description: PGP signature
