kfree.cocci currently triggers on constructs like
drivers/staging/rts5208/spi.c:
596 if (retval < 0) {
597 kfree(buf);
598 rtsx_clear_spi_error(chip);
599 spi_set_err_code(chip, SPI_HW_ERR);
600 TRACE_RET(chip, STATUS_FAIL);
601 }
602
603 rtsx_stor_access_xfer_buf(buf, pagelen, srb, &index, &offset,
TO_XFER_BUF);
with:
./drivers/staging/rts5208/spi.c:603:28-31: ERROR: reference preceded
by free on line 597
but this should be fine - so TRACE_RET is added to the list of calls
"protecting" access to freed objects see drivers/staging/rts5208/trace.h
Acked-by: Julia Lawall <julia.law...@lip6.fr>
Signed-off-by: Nicholas Mc Guire <der.h...@hofr.at>
---
scripts/coccinelle/free/kfree.cocci | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/coccinelle/free/kfree.cocci
b/scripts/coccinelle/free/kfree.cocci
index 577b780..04d3f4f 100644
--- a/scripts/coccinelle/free/kfree.cocci
+++ b/scripts/coccinelle/free/kfree.cocci
@@ -101,6 +101,8 @@ kfree@p1(E,...)
|
return_ACPI_STATUS(...)
|
+ TRACE_RET(...)
+|
E@p2 // bad use
)
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
