On Mon, 07 Jul 2014 13:50:12 +0200 Roman Fietze <roman.fie...@telemotive.de>
wrote:
> This change allows to overwrite the default of the hctosys RTC
> specified in the kernnel configuration by using a kernel parameter in
> the form of
>
> hctosys=rtc<n>
>
Seems reasonable to me, but...
> +char rtc_hctosys_device[RTC_HCTOSYS_DEVICE_SIZE] = CONFIG_RTC_HCTOSYS_DEVICE;
> +
> +static int __init parse_hctosys(char *str)
> +{
> + if (!str)
> + return -EINVAL;
> +
> + if (strlen(str) >= RTC_HCTOSYS_DEVICE_SIZE)
> + return -ENOMEM;
> +
> + strcpy(rtc_hctosys_device, str);
Can we just strdup() this thing and do away with all this futzing around
with the maximum string length?
> + return 0;
> +}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
