Hi Jiri,
As you guys know this allows showing the columns headers on the hists
browsers, used in 'perf top' and 'perf report'. So, to test it, just apply,
fire one of those tools and press 'H' repeatedly.
Please take a look, this should be mostly equivalent to your patchkit in
intent, but fixes some problems and is more consistent with how I first designed
the ui_browser code.
Please let me know if you are ok with it and if I can have your
Acked-by and perhaps Tested-by tags for the code I wrote.
Namhyung, since you reviewed the previous patchkit, I'd like to know
if I can keep the acked-by and perhaps a tested-by too. This should address the
problems that Jiri pointed out in our private conversation.
Thanks,
- Arnaldo
Arnaldo Carvalho de Melo (5):
perf ui browser: Add ->rows to disambiguate from ->height
perf ui browser: Allow overriding refresh_dimensions method
perf hists browser: Introduce gotorc method
perf hists browser: Override ui_browser refresh_dimensions method
perf hists browser: Add support for showing columns header
Jiri Olsa (2):
perf hists browser: Display columns header text on 'H' press
perf hists browser: Add ui.show-headers config file option
tools/perf/ui/browser.c | 37 ++++++------
tools/perf/ui/browser.h | 3 +-
tools/perf/ui/browsers/hists.c | 128 +++++++++++++++++++++++++++++++++++------
tools/perf/util/config.c | 13 +++++
tools/perf/util/symbol.c | 1 +
tools/perf/util/symbol.h | 3 +-
6 files changed, 149 insertions(+), 36 deletions(-)
--
1.9.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
