On Thu, Jun 19, 2014 at 01:11:40PM -0700, j...@joshtriplett.org wrote: > On Thu, Jun 19, 2014 at 09:20:15PM +0200, Johannes Stadlinger wrote: > > This patch inserts a blank line after a declaration to avoid checkpatch > > warning. > > > > Signed-off-by: Johannes Stadlinger <johannes.stadlin...@fau.de> > > Signed-off-by: Maximilian Eschenbacher <maximilian@eschenbacher.email> > > CC: linux-ker...@i4.cs.fau.de > > CC: Greg Kroah-Hartman <gre...@linuxfoundation.org> > > CC: Josh Triplett <j...@joshtriplett.org> > > CC: Himangi Saraogi <himangi...@gmail.com> > > CC: Vitaly Osipov <vitaly.osi...@gmail.com> > > CC: de...@driverdev.osuosl.org > > CC: linux-kernel@vger.kernel.org > > This is one case where I think checkpatch is just wrong; this doesn't > make the code any more (or less) readable. > > Meh-by: Josh Triplett <j...@joshtriplett.org>
We've asked about making checkpatch ignore small blocks but apparently that is a hard thing. It's less work to apply these than to argue about them and adding a space doesn't hurt so meh is correct. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
