On Thu, Jun 19, 2014 at 09:20:17PM +0200, Johannes Stadlinger wrote:
> This patch inserts blank lines after declarations to avoid checkpatch
> warning.
>
> After our fixes in 'wlan-ng/prism2mib.c' there are still two checkpatch
> warnings about lines over 80 characters remaining.
>
> Signed-off-by: Johannes Stadlinger <johannes.stadlin...@fau.de>
> Signed-off-by: Maximilian Eschenbacher <maximilian@eschenbacher.email>
> CC: linux-ker...@i4.cs.fau.de
> CC: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> CC: Josh Triplett <j...@joshtriplett.org>
> CC: Vitaly Osipov <vitaly.osi...@gmail.com>
> CC: Himangi Saraogi <himangi...@gmail.com>
> CC: de...@driverdev.osuosl.org
> CC: linux-kernel@vger.kernel.org
> ---
> drivers/staging/wlan-ng/prism2mib.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wlan-ng/prism2mib.c
> b/drivers/staging/wlan-ng/prism2mib.c
> index bdd3b4c..3ea24d6 100644
> --- a/drivers/staging/wlan-ng/prism2mib.c
> +++ b/drivers/staging/wlan-ng/prism2mib.c
> @@ -85,7 +85,8 @@ struct mibrec {
> u16 parm1;
> u16 parm2;
> u16 parm3;
> - int (*func) (struct mibrec *mib,
> +
> + int (*func)(struct mibrec *mib,
Eliminating the space here makes sense, but checkpatch shouldn't warn
about spaces after declarations between two fields in the middle of a
structure declaration.
> int isget,
> wlandevice_t *wlandev,
> hfa384x_t *hw,
> @@ -722,6 +723,7 @@ static int prism2mib_priv(struct mibrec *mib,
> switch (mib->did) {
> case DIDmib_lnx_lnxConfigTable_lnxRSNAIE:{
> hfa384x_WPAData_t wpa;
> +
> if (isget) {
> hfa384x_drvr_getconfig(hw,
> HFA384x_RID_CNFWPADATA,
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
