On Fri, 20 Jun 2014, Viresh Kumar wrote:
> On Fri, Jun 20, 2014 at 3:04 AM, Thomas Gleixner <t...@linutronix.de> wrote:
> > @@ -176,6 +186,7 @@ static struct spear_shirq spear320_shirq
> > static struct spear_shirq spear320_shirq_intrcomm_ras = {
> > .offset = 11,
> > .nr_irqs = 11,
> > + .mask = ((0x1 << 11) - 1) << 11,
> > .regs = {
> > .enb_reg = -1,
> > .status_reg = SPEAR320_INT_STS_MASK_REG,
>
> If you like, maybe this instead of above diff:
What's wrong with letting the compiler fill it in?
> diff --git a/drivers/irqchip/spear-shirq.c b/drivers/irqchip/spear-shirq.c
> index 3fdda3a..40c5c1b 100644
> --- a/drivers/irqchip/spear-shirq.c
> +++ b/drivers/irqchip/spear-shirq.c
> @@ -281,6 +281,8 @@ static int __init shirq_init(struct spear_shirq
> **shirq_blocks, int block_nr,
> shirq_blocks[i]->base = base;
> shirq_blocks[i]->irq_base = irq_find_mapping(shirq_domain,
> hwirq);
> + shirq_blocks[i]->mask = ((0x1 << shirq_blocks[i]->nr_irqs) -
> 1)
> + << shirq_blocks[i]->offset;
> shirq_blocks[i]->irq = irq_of_parse_and_map(np, i);
>
> spear_shirq_register(shirq_blocks[i]);
>
>
> > @@ -239,7 +250,7 @@ static void shirq_handler(unsigned irq,
> >
> > chip->irq_ack(idata);
> >
> > - mask = ((0x1 << shirq->nr_irqs) - 1) << shirq->offset;
> > + mask = shirq->mask;
> > while ((val = readl(shirq->base + shirq->regs.status_reg) &
> > mask)) {
> >
> >
> >
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
