On Wed, 18 Jun 2014, Michal Nazarewicz wrote: > On Wed, Jun 18 2014, Yang,Wei wrote: > > On 06/17/2014 10:18 PM, Alan Stern wrote: > >> That is a strange question to ask. If you did not know that I approved > >> the patch, why did you insert my Acked-By:? > > > I added your Acked-By, as when you reviewed V3, you mentioned that I > > *may* add your Acked-by in this patch. If I misunderstood your point, I > > am so sorry for that. > > Alan's point is that if you have any doubts whether someone approves > your patch you should *not* add their Acked-by. So adding someone's > Acked-by and then asking if they are fine with the patch is > contradictory -- the former indicates that you believe the person is > fine with the patch, while the latter shows that you aren't. > > Alan wrote: > > >>> With that change, you may add > >>> > >>> Acked-by: Alan Stern <st...@rowland.harvard.edu> > > so after adding “that change” you are in your right to add Alan's > Acked-by, but what that also means is that Alan will be fine with the > patch if you make the requested change, so you don't need to ask for an > opinion again. > > PS. Note that “having any doubts” also means that if someone gave you > their Acked-by, but then you substantially rewrite the patch, you > probably should consider removing their Acked-by.
Exactly so. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
