On Mon, 2014-06-16 at 22:00 +0000, Paul Zimmerman wrote: > > From: Joe Perches [mailto:j...@perches.com] > > Sent: Sunday, June 15, 2014 1:38 PM > > > > Use the zeroing function instead of dma_alloc_coherent & memset(,0,) > > > > Signed-off-by: Joe Perches <j...@perches.com> > > --- > > drivers/usb/dwc2/hcd_ddma.c | 20 +++++++------------- > > drivers/usb/host/uhci-hcd.c | 7 +++---- > > 2 files changed, 10 insertions(+), 17 deletions(-) > > > > diff --git a/drivers/usb/dwc2/hcd_ddma.c b/drivers/usb/dwc2/hcd_ddma.c > > index 3376177..ab8d7fc 100644 > > --- a/drivers/usb/dwc2/hcd_ddma.c > > +++ b/drivers/usb/dwc2/hcd_ddma.c > > @@ -87,17 +87,12 @@ static u16 dwc2_frame_incr_val(struct dwc2_qh *qh) > > static int dwc2_desc_list_alloc(struct dwc2_hsotg *hsotg, struct dwc2_qh > > *qh, > > gfp_t flags) > > { > > - qh->desc_list = dma_alloc_coherent(hsotg->dev, > > - sizeof(struct dwc2_hcd_dma_desc) * > > - dwc2_max_desc_num(qh), &qh->desc_list_dma, > > - flags); > > - > > + qh->desc_list = dma_zalloc_coherent(hsotg->dev, > > + sizeof(struct dwc2_hcd_dma_desc) * > > dwc2_max_desc_num(qh), > > + &qh->desc_list_dma, flags); > > This will cause checkpatch to complain about a too-long line, surely?
Hi Paul. It does and I don't care. > If you fix that, you can add my acked-by for the dwc2 parts. If you care that much, I can fix it for you, but I think it's better as a long line. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
