On 06/09/14 14:47, Michal Marek wrote: > Dne 3.6.2014 20:25, Julia Lawall napsal(a): >> From: Stephen Boyd <sb...@codeaurora.org> >> >> Failure to terminate an of_device_id table can lead to confusing >> failures depending on where the compiler places the array. Add a >> check to make sure these tables are terminated. Thanks to Mitchel >> Humpherys for coming up with the pattern initially. >> >> Cc: Mitchel Humpherys <mitch...@codeaurora.org> >> Cc: Julia Lawall <julia.law...@lip6.fr> >> Cc: Gilles Muller <gilles.mul...@lip6.fr> >> Cc: Nicolas Palix <nicolas.pa...@imag.fr> >> Cc: Grant Likely <grant.lik...@linaro.org> >> Cc: Rob Herring <robh...@kernel.org> >> Cc: devicet...@vger.kernel.org >> Signed-off-by: Stephen Boyd <sb...@codeaurora.org> >> Acked-by: Grant Likely <grant.lik...@linaro.org> >> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> >> >> --- >> >> v3: Removed unneeded rule bad_of_table. Placed * in context rule on the >> closing brace; putting it on the field caused all fields to be marked. >> >> v4: corrected authorship >> >> scripts/coccinelle/misc/of_table.cocci | 62 >> +++++++++++++++++++++++++++++++++ >> 1 file changed, 62 insertions(+) > Applied to kbuild.git#misc, thanks. BTW, what is so special about of > device drivers? Shouldn't we check for missing sentinels in all kinds of > device tables? >
Yes the rule should probably be expanded to cover more tables. I guess this is just more noticeable because a driver may match some device that it isn't supposed to match and start writing random bits to registers it shouldn't be, causing the system to hang. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
