Move edac_op_state assignment operations to probe, then convert to
module_platform_drive() to eliminate boilerplate code, and use
cpc925_printk instead of printk.
Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com>
---
drivers/edac/cpc925_edac.c | 33 +++++++--------------------------
1 files changed, 7 insertions(+), 26 deletions(-)
diff --git a/drivers/edac/cpc925_edac.c b/drivers/edac/cpc925_edac.c
index df6575f..8e3192a 100644
--- a/drivers/edac/cpc925_edac.c
+++ b/drivers/edac/cpc925_edac.c
@@ -944,6 +944,12 @@ static int cpc925_probe(struct platform_device *pdev)
edac_dbg(0, "%s platform device found!\n", pdev->name);
+ cpc925_printk(KERN_INFO, CPC925_EDAC_REVISION "\n");
+ cpc925_printk(KERN_INFO, "\t(c) 2008 Wind River Systems, Inc\n");
+
+ /* Only support POLL mode so far */
+ edac_op_state = EDAC_OPSTATE_POLL;
+
if (!devres_open_group(&pdev->dev, cpc925_probe, GFP_KERNEL)) {
res = -ENOMEM;
goto out;
@@ -1065,32 +1071,7 @@ static struct platform_driver cpc925_edac_driver = {
}
};
-static int __init cpc925_edac_init(void)
-{
- int ret = 0;
-
- printk(KERN_INFO "IBM CPC925 EDAC driver " CPC925_EDAC_REVISION "\n");
- printk(KERN_INFO "\t(c) 2008 Wind River Systems, Inc\n");
-
- /* Only support POLL mode so far */
- edac_op_state = EDAC_OPSTATE_POLL;
-
- ret = platform_driver_register(&cpc925_edac_driver);
- if (ret) {
- printk(KERN_WARNING "Failed to register %s\n",
- CPC925_EDAC_MOD_STR);
- }
-
- return ret;
-}
-
-static void __exit cpc925_edac_exit(void)
-{
- platform_driver_unregister(&cpc925_edac_driver);
-}
-
-module_init(cpc925_edac_init);
-module_exit(cpc925_edac_exit);
+module_platform_driver(cpc925_edac_driver);
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Cao Qingtao <qingtao....@windriver.com>");
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
