> The UCB1200 / UCB1300 driver uses the MCP_SA11X0 driver, which > can be a loadable module, but this results in a link error > when UCB1200 itself is built-in: > > drivers/built-in.o: In function `ucb1x00_io_set_dir': > :(.text+0x4a364): undefined reference to `mcp_reg_write' > drivers/built-in.o: In function `ucb1x00_io_write': > :(.text+0x4a3dc): undefined reference to `mcp_reg_write' > drivers/built-in.o: In function `ucb1x00_io_read': > :(.text+0x4a400): undefined reference to `mcp_reg_read' > drivers/built-in.o: In function `ucb1x00_adc_enable': > :(.text+0x4a460): undefined reference to `mcp_enable' > ... > > This can easily be resolved by making CONFIG_MCP_UCB1200 itself > a tristate option, since that causes Kconfig to track the > dependency correctly. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > --- > drivers/mfd/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks. > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index ee8204c..4370692 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -1248,7 +1248,7 @@ config MCP_SA11X0 > > # Chip drivers > config MCP_UCB1200 > - bool "Support for UCB1200 / UCB1300" > + tristate "Support for UCB1200 / UCB1300" > depends on MCP_SA11X0 > select MCP > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
