On Tue, Apr 29, 2014 at 04:36:13PM -0700, Zi Shen Lim wrote: This looks good to me, modulo a couple of really tiny nitpicks.
Reviwed-by: Mark Brown <broo...@linaro.org>
I'm just doing some brief testing now, I'll repost my series with this
and Lorenzo's changes included shortly assuming no issues.
> if (cpuid_topo->cluster_id == -1) {
> - /*
> - * DT does not contain topology information for this cpu.
> - */
> + /* No topology information for this cpu ?! */
> pr_debug("CPU%u: No topology information configured\n", cpuid);
> return;
> }
Now that we have MPIDR support (well, will with this patch) this should
probably be raised to a pr_err() since we've got ourselves confused
somehow if it ever happens - we should always be able to get topology
from MPIDR. I'll tweak this when I repost.
> + pr_debug("CPU%u: cluster %d core %d thread %d mpidr %llx\n",
> + cpuid, cpuid_topo->cluster_id, cpuid_topo->core_id,
> + cpuid_topo->thread_id, mpidr);
I do wonder if we should print this either unconditionally or not at
all (rather than only if using MPIDR), I know Catalin and/or Lorenzo
weren't keen on noise but it is just at debug level and it's nice and
easy to refer to.
signature.asc
Description: Digital signature
