Thank's for your answers, will try to look deeper, >> > >> > If we want to sovle the truncation issue then we need to think of >> > shorter names for BassPODxtLive, BassPODxtPro, PODStudioUX1, and >> > PODStudioUX2. >> > >> >> In that case I suggest compile time assertions that ids and names fit > > That sounds like some magic code which I would love to see. :) > >> and a WARN_ON + -EINVAL in line6_init_audio to catch future >> offenders. > > Returning -EINVAL is a bad idea because it would break the driver > completely and make it unusable. > >> >> As a side note I'm not sure if pod_try_init from >> drivers/staging/line6/pod.c >> cleans up properly after failed line6_init_audio. > > Yeah. It doesn't seem to clean up at all. >
Laurent Navet. -- « On ne résout pas un problème avec les modes de pensée qui l’ont engendré. » « You cannot solve current problems with current thinking. Current problems are the result of current thinking » -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
