Alexandre,
On Wed, Apr 23, 2014 at 04:01:07PM +0200, Alexandre Belloni wrote:
> Add sdio clocks to the berlin2q.dtsi
> Also reorder the syspll node
>
> Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com>
> ---
> arch/arm/boot/dts/berlin2q.dtsi | 28 +++++++++++++++++++++-------
> 1 file changed, 21 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
> index 5925e6a16749..0fc826305614 100644
> --- a/arch/arm/boot/dts/berlin2q.dtsi
> +++ b/arch/arm/boot/dts/berlin2q.dtsi
> @@ -102,13 +102,6 @@
> reg = <0xdd0170 0x8>;
> };
>
> - syspll: syspll@ea0030 {
> - compatible = "marvell,berlin2q-pll";
> - clocks = <&smclk>;
> - #clock-cells = <0>;
> - reg = <0xea0030 0x8>;
> - };
> -
> apb@e80000 {
> compatible = "simple-bus";
> #address-cells = <1>;
> @@ -191,6 +184,27 @@
> };
> };
>
> + syspll: syspll@ea0030 {
> + compatible = "marvell,berlin2q-pll";
> + clocks = <&smclk>;
> + #clock-cells = <0>;
> + reg = <0xea0030 0x8>;
> + };
> +
> + sdio0xinclk: sdio0xinclk@ea0158 {
> + compatible = "marvell,berlin-clk";
> + clocks = <&syspll>;
> + #clock-cells = <0>;
> + reg = <0xea0158 4>;
I believe you can use
reg = <0xea0158 0x4>;
since you used an hex value in the previous node. Plus we tend to use
hex values elsewhere too.
> + };
> +
> + sdio1xinclk: sdio1xinclk@ea015c {
> + compatible = "marvell,berlin-clk";
> + clocks = <&syspll>;
> + #clock-cells = <0>;
> + reg = <0xea015c 4>;
Ditto. This also applies to BG2/BG2CD and the documentation patches.
Thanks!
Antoine
> + };
> +
> apb@fc0000 {
> compatible = "simple-bus";
> #address-cells = <1>;
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-ker...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
