Sebastian,
On Tue, Apr 22, 2014 at 07:35:27PM +0200, Sebastian Hesselbarth wrote:
> On 04/22/2014 10:27 AM, Antoine Ténart wrote:
[…]
> > + sdhci0: sdhci@ab0000 {
> > + compatible = "mrvl,pxav3-mmc";
> > + reg = <0xab0000 0x200>;
> > + clocks = <&sdio1clk>;
> > + interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
> > + status = "disabled";
> > + };
> > +
> > + sdhci1: sdhci@ab0800 {
> > + compatible = "mrvl,pxav3-mmc";
> > + reg = <0xab0800 0x200>;
> > + clocks = <&sdio1clk>;
> > + interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
> > + status = "disabled";
> > + };
> > +
> > + sdhci2: sdhci@ab1000 {
>
> Didn't Jisheng ask for sdhci2 being registered at mmc0?
Yes sure, but I don't know if he agreeded on this solution. I'll ask him.
Otherwise aliases seems ok from my point of view.
> Renaming the node labels will not help, but have you tried using an:
>
> aliases {
> mmc0 = &sdhci2;
> mmc1 = &sdhci0;
> mmc2 = &sdhci1;
> };
>
> node and set the platform_device's .id field with what you get
> from of_alias_get_id(np, "mmc")?
>
> @Chris, Ulf: Is there any generic alias, e.g. "sdhci", you prefer for
> drivers/mmc so we can put it into sdhci_get_of_property()?
I'd also like the subsystem maintainers to give their opinion on this
before updating.
Thanks!
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
