Hi Eric, ----- Original Message ----- > From: "Eric Bénard" <e...@eukrea.com> > To: "Hubert Chaumette" <hchaume...@adeneo-embedded.com> > Cc: linux-arm-ker...@lists.infradead.org, li...@arm.linux.org.uk, "shawn guo" > <shawn....@linaro.org>, > linux-kernel@vger.kernel.org, ker...@pengutronix.de > Sent: Friday, March 21, 2014 10:23:20 PM > Subject: Re: [PATCH] ARM: i.MX6: update KSZ9031 phy fixup > > Hi Hubert, > > Le Fri, 21 Mar 2014 18:08:07 +0100, > Hubert Chaumette <hchaume...@adeneo-embedded.com> a écrit : > > > > > Update KSZ9031RN phy fixup for Congatec conga-QEVAL and conga-QMX6 combo : > > set RGMII GTX_CLK and RX_CLK pad skew to +0.96ns. > > > > Signed-off-by: Hubert Chaumette <hchaume...@adeneo-embedded.com> > > --- > > arch/arm/mach-imx/mach-imx6q.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/arm/mach-imx/mach-imx6q.c > > b/arch/arm/mach-imx/mach-imx6q.c > > index 76e5db4..db307c2 100644 > > --- a/arch/arm/mach-imx/mach-imx6q.c > > +++ b/arch/arm/mach-imx/mach-imx6q.c > > @@ -77,6 +77,9 @@ static int ksz9031rn_phy_fixup(struct phy_device *dev) > > mmd_write_reg(dev, 2, 5, 0); > > mmd_write_reg(dev, 2, 8, 0x003ff); > > > > + /* For Congatec conga-QMX6 board */ > > + mmd_write_reg(dev, 0x02, 0x06, 0xffff); > > + > > return 0; > > } > > > that's board specific (the needed delay depends on the routing delay on > the PCB), so this should not go in a generic file. > > Eric >
I admit it may need to be in a separate function, but this file already contains board-specific fixups (for imx6q sabrelite, Data Modul eDM-QMX6). Anyway, do you have any suggestion for the location I should put it ? Regards, Hubert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
